Factor common logic out of add_*_parameter methods#676
Open
everyday847 wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Factor common logic out of add_*_parameter methods#676everyday847 wants to merge 1 commit intoRosettaCommons:mainfrom
everyday847 wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
Extract a private configure_and_add_parameter() helper that handles the shared configuration steps (name, description, units, type, capabilities, global flag) and add_parameter() call. Each add_*_parameter() and add_custom_parameter() now only constructs the type-specific object, sets any conditional default value, and delegates to the helper. Also replace bare new with make_shared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a private
configure_and_add_parameter()helper that handles the shared configuration steps (name, description, units, type, capabilities, global flag) andadd_parameter()call. Eachadd_*_parameter()andadd_custom_parameter()now only constructs the type-specific object, sets any conditional default value, and delegates to the helper. Also replace barenewwithmake_shared.